-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix email notifications for comments on goals #984
Comments
ZenHub #984 - Fix Comment Name in Email
@telusdcinco The delegate supervisor when adds a comment to the goal, his name is not displayed in the email Some additional notifications issues are addressed in #1032 |
ZenHub #984 - Fix Comment Name in Email
ZenHub #984 - Fix Comment Name in Email
ZenHub #984 - Fix Comment Name in Email
Previous fix was not pushed to Test. Re-pushing fix to match in-app name in the email notification. |
Test validated. |
ZenHub #984 - Fix Comment Name in Email
ZenHub #984 - Fix Comment Name in Email
Current Situation
Currently, when a shared / delegated supervisor comments on an employees goal, the employee receives the correct notification on the app homepage, but an incorrect notification via email. The in-app notification shows the name of the person who made the comment while the email shows the name of their PeopleSoft supervisor as the person that made the comment, even if it was someone else. The notification template defines that variable as "the person that made the comment" regardless of whether it was a supervisor or a colleague, etc. but it seems like the logic in the background is grabbing the direct supervisor name and using that.
Desired Result
The email and in-app notifications both correctly identify the person who made the comment on the employee's goal.
The text was updated successfully, but these errors were encountered: