Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email notifications for comments on goals #984

Closed
Travis-A-Clark opened this issue Jun 1, 2023 · 3 comments
Closed

Fix email notifications for comments on goals #984

Travis-A-Clark opened this issue Jun 1, 2023 · 3 comments
Assignees
Labels
bug Something isn't working PO Approved PO has reviewed and approved

Comments

@Travis-A-Clark
Copy link
Collaborator

Current Situation

Currently, when a shared / delegated supervisor comments on an employees goal, the employee receives the correct notification on the app homepage, but an incorrect notification via email. The in-app notification shows the name of the person who made the comment while the email shows the name of their PeopleSoft supervisor as the person that made the comment, even if it was someone else. The notification template defines that variable as "the person that made the comment" regardless of whether it was a supervisor or a colleague, etc. but it seems like the logic in the background is grabbing the direct supervisor name and using that.

Desired Result
The email and in-app notifications both correctly identify the person who made the comment on the employee's goal.

@Travis-A-Clark Travis-A-Clark added the bug Something isn't working label Jun 1, 2023
@Travis-A-Clark Travis-A-Clark added this to the MVP 4 - July 7 milestone Jun 1, 2023
telusdcinco added a commit that referenced this issue Jul 11, 2023
ZenHub #984 - Fix Comment Name in Email
@steffipravasi steffipravasi self-assigned this Jul 11, 2023
@steffipravasi
Copy link
Collaborator

steffipravasi commented Jul 12, 2023

@telusdcinco The delegate supervisor when adds a comment to the goal, his name is not displayed in the email
In the following emailScreenshot 2023-07-12 at 12.44.11 AM.png, the name expected is Bauer,Connie
Comment:Screenshot 2023-07-12 at 12.44.48 AM.png
In-app:Screenshot 2023-07-12 at 12.46.23 AM.png

Some additional notifications issues are addressed in #1032

@steffipravasi steffipravasi added the test failed Issue didn't pass testing and requires more work label Jul 12, 2023
telusdcinco added a commit that referenced this issue Jul 12, 2023
ZenHub #984 - Fix Comment Name in Email
telusdcinco added a commit that referenced this issue Jul 12, 2023
ZenHub #984 - Fix Comment Name in Email
telusdcinco added a commit that referenced this issue Jul 12, 2023
ZenHub #984 - Fix Comment Name in Email
@telusdcinco
Copy link
Collaborator

Previous fix was not pushed to Test. Re-pushing fix to match in-app name in the email notification.

@steffipravasi
Copy link
Collaborator

Test validated.
Correct names are displayed for in-app and email notifications when a direct or delegate supervisor adds a comment to a goal.
Ready for PO review.

@Travis-A-Clark Travis-A-Clark added PO Approved PO has reviewed and approved and removed test failed Issue didn't pass testing and requires more work labels Jul 12, 2023
telusdcinco added a commit that referenced this issue Jul 13, 2023
ZenHub #984 - Fix Comment Name in Email
telusdcinco added a commit that referenced this issue Jul 13, 2023
ZenHub #984 - Fix Comment Name in Email
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PO Approved PO has reviewed and approved
Projects
None yet
Development

No branches or pull requests

3 participants