Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TNO-2044 Tags major fixes #1379

Merged
merged 2 commits into from
Jan 5, 2024
Merged

TNO-2044 Tags major fixes #1379

merged 2 commits into from
Jan 5, 2024

Conversation

fbarreta
Copy link
Collaborator

@fbarreta fbarreta commented Jan 5, 2024

  • Remove on blur property from editor that was stripping the tags
  • Set field value on change. It was holding the validation while inserting new medias
  • Enabled case insensitive tags

@fbarreta fbarreta added bug Something isn't working tno-core update Indicates that there have been changes to our tno-core package, which can pose concurrency issues. editor labels Jan 5, 2024
@fbarreta fbarreta requested a review from Fosol January 5, 2024 03:32
@fbarreta fbarreta self-assigned this Jan 5, 2024
Fosol
Fosol requested changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@Fosol Fosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have published tno-core:0.1.5 for you. Update PR and we'll merge. Thanks for solving this riddle. Looks like I moved the component into our core library and we lost the history on who wrote this extraction.

@Fosol Fosol merged commit 28320fd into dev Jan 5, 2024
2 checks passed
@Fosol Fosol deleted the TNO-2044-tag-fixes branch January 5, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fosol Fosol Fosol approved these changes

Assignees

@fbarreta fbarreta

Labels
bug Something isn't working editor tno-core update Indicates that there have been changes to our tno-core package, which can pose concurrency issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbarreta @Fosol