Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TNO-2162 Fix reports #1383

Merged
merged 1 commit into from
Jan 6, 2024
Merged

TNO-2162 Fix reports #1383

merged 1 commit into from
Jan 6, 2024

Conversation

Fosol
Copy link
Collaborator

@Fosol Fosol commented Jan 6, 2024

A number of fixes for reports.

  • Resolving preview issues
  • Resolving view instance issues
  • Adding list of subscribers to a report (view only)
  • Disabling form fields (hiding some) when report instance has been sent

@Fosol Fosol added bug Something isn't working subscriber PR contains changes towards the subscriber application, labels Jan 6, 2024
@Fosol Fosol self-assigned this Jan 6, 2024
@@ -18,7 +18,7 @@ export const ReportInstanceView: React.FC<IReportInstanceViewProps> = ({ instanc
async (instanceId: number) => {
try {
const response = await viewReportInstance(instanceId);
storeReportOutput(response);
storeReportOutput({ ...response, instanceId });
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed issue where it wouldn't refresh the preview for the report

namespace TNO.API.Areas.Subscriber.Models.Report;

/// <summary>
/// UserReportModel class, provides a model that represents a subscriber to a report.
/// </summary>
public class UserReportModel : AuditColumnsModel
public class UserReportModel : UserModel
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed model output issue for subscribers

var searchResults = await this.Api.GetContentForReportInstanceIdAsync(instance.Id);
var sectionContent = searchResults.GroupBy(r => r.SectionName).ToDictionary(r => r.Key, r =>
var sectionContent = sections.ToDictionary(s => s.Name, section =>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed bug with generating a report from an instance

@Fosol Fosol merged commit d09647e into bcgov:dev Jan 6, 2024
2 checks passed
@Fosol Fosol deleted the tno-2162 branch January 6, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working subscriber PR contains changes towards the subscriber application,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant