TNO-1948: Fix select checkbox issue #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mihailistov
commented
Jan 9, 2024
mihailistov
commented
Fosol
approved these changes
Jan 9, 2024
| if (!isSelected) { | ||
| (document.getElementById(children) as HTMLInputElement).checked = false; | ||
| } | ||
| (document.getElementById(children) as HTMLInputElement).checked = isSelected; |
There was a problem hiding this comment.
using the DOM isn't ideal. I wonder why this was implemented this way originally?
There was a problem hiding this comment.
@Fosol good call, I didn't really question it. I just pushed some changes that is an alternative, more minimalist way. I tested as best I could and don't see any weird side effects. Let me know if you want me to revert it back to my initial commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.