Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #tno-2221 - added preview button for event of the day #1412

Merged
merged 1 commit into from
Jan 13, 2024
Merged

feat: #tno-2221 - added preview button for event of the day #1412

merged 1 commit into from
Jan 13, 2024

Conversation

kylgarmor
Copy link
Contributor

No description provided.

@kylgarmor kylgarmor added enhancement New feature or request DB Migration A DB Migration may require refreshing or simply updating your database. tno-core update Indicates that there have been changes to our tno-core package, which can pose concurrency issues. labels Jan 12, 2024
@kylgarmor kylgarmor requested a review from Fosol January 12, 2024 22:24
@kylgarmor kylgarmor self-assigned this Jan 12, 2024
Fosol
Fosol approved these changes Jan 13, 2024
View reviewed changes
Copy link
Collaborator

@Fosol Fosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have bothered with the DB migration due to the issue of reports not always existing in each environment. Hope this won't break when I push to PROD

@Fosol Fosol merged commit 14199b9 into bcgov:dev Jan 13, 2024
3 checks passed
@kylgarmor
Copy link
Contributor Author

That report should exist as its created by a prior migration...

@kylgarmor kylgarmor deleted the tno-2221 branch March 12, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fosol Fosol Fosol approved these changes

Assignees

@kylgarmor kylgarmor

Labels
DB Migration A DB Migration may require refreshing or simply updating your database. enhancement New feature or request tno-core update Indicates that there have been changes to our tno-core package, which can pose concurrency issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylgarmor @Fosol