Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TNO-2143: Only show featured items on homepage #1417

Merged
merged 2 commits into from
Jan 16, 2024
Merged

TNO-2143: Only show featured items on homepage #1417

merged 2 commits into from
Jan 16, 2024

Conversation

jdtoombs
Copy link
Collaborator

In this PR:

  • Homepage (Featured Stories) will now only show content that is marked with the homepage action from the editor application

@jdtoombs jdtoombs added the bug Something isn't working label Jan 16, 2024
@jdtoombs jdtoombs requested a review from Fosol January 16, 2024 01:38
@jdtoombs jdtoombs self-assigned this Jan 16, 2024
@jdtoombs jdtoombs added subscriber PR contains changes towards the subscriber application, tno-core update Indicates that there have been changes to our tno-core package, which can pose concurrency issues. labels Jan 16, 2024
Fosol
Fosol requested changes Jan 16, 2024
View reviewed changes
app/subscriber/src/features/search-page/utils/getActionFilter.ts Outdated
@@ -8,6 +8,7 @@ import { IActionModel, IFilterActionSettingsModel, IFilterSettingsModel } from '
*/
export const getActionFilters = (filter: IFilterSettingsModel, actions: IActionModel[]) => {
const result: IFilterActionSettingsModel[] = [];
console.log(filter);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

app/subscriber/src/features/home/Home.tsx Outdated
},
actions,
),
),
);
}, [fetchResults, filter, settings, contentType]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix or explain

app/subscriber/yarn.lock Outdated
@@ -10568,7 +10568,7 @@ __metadata:
sass-extract-js: 0.4.0
sass-extract-loader: 1.1.0
styled-components: 5.3.9
tno-core: 0.1.11
tno-core: ./tno-core-0.1.11.tgz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

@Fosol Fosol merged commit 504d38b into bcgov:dev Jan 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fosol Fosol Fosol approved these changes

Assignees

@jdtoombs jdtoombs

Labels
bug Something isn't working subscriber PR contains changes towards the subscriber application, tno-core update Indicates that there have been changes to our tno-core package, which can pose concurrency issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdtoombs @Fosol