Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TNO-2131 Fix report template sections #1427

Merged
merged 1 commit into from
Jan 18, 2024
Merged

TNO-2131 Fix report template sections #1427

merged 1 commit into from
Jan 18, 2024

Conversation

Fosol
Copy link
Collaborator

@Fosol Fosol commented Jan 18, 2024

Only report sections of Content and Gallery will be listed in the Table of Contents.

Run make renew to update your local environments

Summary

  • Publish tno-core:0.1.15
  • Add DB migration 1.0.110
  • Updated Editor app
  • Updated Subscriber app
  • Moved the ReportSection.Settings.SectionType to ReportSection.SectionType
  • Updated default report

Report Template

image

@Fosol Fosol added bug Something isn't working DB Migration A DB Migration may require refreshing or simply updating your database. subscriber PR contains changes towards the subscriber application, tno-core update Indicates that there have been changes to our tno-core package, which can pose concurrency issues. editor labels Jan 18, 2024
@Fosol Fosol self-assigned this Jan 18, 2024
Publish tno-core:0.1.15
Add DB migration 1.0.110
@Fosol Fosol marked this pull request as ready for review January 18, 2024 15:52
{
@* Table of Contents Section *@
var tocCount = 0;
@foreach (var tableSection in Sections.Where(s => s.Value.Settings.SectionType != ReportSectionType.TableOfContents))
@foreach (var tableSection in Sections.Where(s => new [] {ReportSectionType.Content, ReportSectionType.Gallery}.Contains(s.Value.SectionType)))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only include these two types in the Table of Content.s

@@ -0,0 +1,21 @@
INSERT INTO public."setting" (
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the default report template is pointing to the correct value. This however is linked to the friendly name of the template, which could be manually changed...

@Fosol Fosol merged commit a50af3b into bcgov:dev Jan 18, 2024
3 checks passed
@Fosol Fosol deleted the tno-2131 branch January 18, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DB Migration A DB Migration may require refreshing or simply updating your database. editor subscriber PR contains changes towards the subscriber application, tno-core update Indicates that there have been changes to our tno-core package, which can pose concurrency issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant