Fix topic score rules #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DB migration 1.0.10
Fosol
commented
Apr 3, 2023
| pageMax: yup | ||
| .string() | ||
| .optional() | ||
| .when('pageMin', (pageMin: string, schema: any) => { |
There was a problem hiding this comment.
Validation to ensure the max page is greater than the minimum page.
| rPageMax !== undefined && | ||
| (vPage === 0 || vPage < rPageMin || vPage > rPageMax)) || | ||
| (cPageMin !== undefined && | ||
| vcPage !== cPageMin && |
There was a problem hiding this comment.
Handle letter comparison too.
| @@ -31,7 +31,7 @@ export const initialContentState: IContentState = { | |||
| sort: [], | |||
| }, | |||
| filterAdvanced: { | |||
| fieldType: fieldTypes[3].value, | |||
| fieldType: fieldTypes[1].value, | |||
| @@ -11,8 +11,8 @@ public override void Configure(EntityTypeBuilder<TopicScoreRule> builder) | |||
| builder.Property(m => m.SourceId).IsRequired(); | |||
| builder.Property(m => m.SeriesId); | |||
| builder.Property(m => m.Section).HasMaxLength(100); | |||
| builder.Property(m => m.PageMin); | |||
| builder.Property(m => m.PageMax); | |||
| builder.Property(m => m.PageMin).HasMaxLength(5); | |||
There was a problem hiding this comment.
Change to string value. I don't know how this wasn't included in my prior PR. I think there was a git merge issue I must have run into because I did convert this to a string at one point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing topic score rules admin page validation. Also defaulting advanced filter to source.
Add DB migration 1.0.10.