Subscriber Home & View Content #659
Conversation
jdtoombs
added
enhancement
app/subscriber/public/favicon.png
Outdated
There was a problem hiding this comment.
Need to ask Bobbi for a smaller version for tab icon
There was a problem hiding this comment.
Leaving out of tno-core for now as changes coming to our tables
| @@ -2,17 +2,8 @@ | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="utf-8" /> | |||
| <link rel="icon" href="%PUBLIC_URL%/favicon.ico" /> | |||
There was a problem hiding this comment.
Shouldn't we be including this with a new icon?
There was a problem hiding this comment.
We have a few places that this was being pulled from, I left it in the manifest.json but we could. Will do another look over to make sure everything is in line
| @@ -62,6 +62,7 @@ public IPaged<Content> FindWithDatabase(ContentFilter filter, bool asNoTracking | |||
| .Include(c => c.Source) | |||
| .Include(c => c.Series) | |||
| .Include(c => c.License) | |||
| .Include(c => c.TonePoolsManyToMany).ThenInclude(ct => ct.TonePool) | |||
There was a problem hiding this comment.
While helpful, I don't think this is going to help. We shouldn't be using this for search from the frontend anymore. We're using elasticsearch. The method below this one.
jdtoombs
force-pushed
the
tno-1121
branch
4 times, most recently
from
c09b28d
to
e4c1b14
Compare
|
Just trying to figure out elastic search, missing some fields and learning the equivalent for .Include() |
|
@Fosol - being stumped by this - think I will just mark it as ready for review as is. Currently will not show tone icons on list view - but the rest of the code can be reviewed. Might be good for me to switch gears and finish off the filters first. This will need to be merged before my other PR that I am working on. Will figure out including |
| </Row> | ||
| <Row justifyContent="center" className="date-navigator"> | ||
| <FaAngleLeft /> | ||
| 2023-03-04 |
There was a problem hiding this comment.
Just a placeholder for my next ticket!
PR Includes