Task/update node, prettier, eslint #3786
Conversation
| @@ -71,8 +71,8 @@ | |||
| "cypress": "start-server-and-test start:cypress 3030 cy:open", | |||
| "cypress:ci": "start-server-and-test start:cypress 3030 cy:run", | |||
| "eject": "react-scripts eject", | |||
| "lint": "eslint './src/**/*.{ts,tsx}'", | |||
| "lint:fix": "eslint --fix './src/**/*.{ts,tsx}'", | |||
| "lint": "eslint", | |||
There was a problem hiding this comment.
I'm assuming this change widens the file types that are linted? So typescript, tsx, javascript, etc?
There was a problem hiding this comment.
whoops. i made comments on last pr and didn't move them. one sec.
There was a problem hiding this comment.
moved all to eslint.config to keep it in one place
| @@ -1,4 +1,7 @@ | |||
| module.exports = { | |||
| eslint: { | |||
| enable: false | |||
| }, | |||
There was a problem hiding this comment.
by default creat react app runs eslint itself on each build. but since our ci is always doing that it seems unnecessary. this will speed up the build. plus it uses different eslint version so comes up with different problems.
There was a problem hiding this comment.
Nice catch, is it possible to add that explanation as a comment in the file?
| @@ -1111,7 +1111,7 @@ | |||
| "rate_of_spread": 0.001902355415765236, | |||
| "hfi": 1.8253517760238567, | |||
| "intensity_group": 1, | |||
| "sixty_minute_fire_size": 9.998822417249202e-07, | |||
| "sixty_minute_fire_size": 9.998822417249202e-7, | |||
There was a problem hiding this comment.
another prettier thing. seems weird. is it ok?
There was a problem hiding this comment.
These are test fixtures, so as long as tests pass it's fine. Looks like just removing leading zeroes from floating point exponent notation.
| "eslint-plugin-react-hooks": "^4.4.0", | ||
| "eslint": "^9.7.0", | ||
| "eslint-plugin-react-hooks": "^4.6.2", | ||
| "globals": "^15.8.0", |
There was a problem hiding this comment.
the eslint config file is added by a npx command. and then it uses some old version of globals that's floating around from other packages. which has a white space error that now gets linted so i manually installed this version. seems silly but...?
There was a problem hiding this comment.
Yeah that's fine, thanks for catching and explaining this too.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3786 +/- ##
==========================================
+ Coverage 79.36% 79.39% +0.02%
==========================================
Files 297 297
Lines 10882 10882
Branches 525 525
==========================================
+ Hits 8637 8640 +3
+ Misses 2100 2097 -3
Partials 145 145 ☔ View full report in Codecov by Sentry. |
1. updates node to 20 2. updates eslint 3. updates prettier 4. yarn.lock sources got changed to registry.npmjs. i guess that's a problem? or not? all the changes in json data files are due to new prettier. closes bcgov#3516 closes bcgov#2989
this pr
all the changes in json data files are due to new prettier.
closes #3516
closes #2989
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator