Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patroni pod health checks #436

Merged
merged 32 commits into from
Aug 25, 2020
Merged

Conversation

andrea-williams
Copy link
Collaborator

No description provided.

@andrea-williams andrea-williams marked this pull request as ready for review August 24, 2020 22:11
Copy link
Contributor

@Sybrand Sybrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that switch to using an environment variable: PATHFINDER_BASE_URI

Also - remember - before deploying to prod, we have to tag the latest patroni image as 10 and test it. Would also be smart to tag the old image with something to keep it around for a while.

Oh - also - can you check with Kyubin what he wanted removed from the global config template while we're in there. We can remove the SPOTWX one.

api/app/main.py Outdated Show resolved Hide resolved
api/app/tests/test_health.py Outdated Show resolved Hide resolved
@@ -16,3 +16,7 @@ POSTGRES_PASSWORD="wps"
POSTGRES_DATABASE="wps"
POSTGRES_PORT="5432"
PORT="8080"
PATHFINDER_BASE_URI=https://console.pathfinder.gov.bc.ca:8443
PROJECT_NAMESPACE=openshift_project_namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add an env variable for this because we already keep track of this (check out openshift/scripts/oc_deploy.sh line 29)

api/app/main.py Outdated Show resolved Hide resolved
api/app/tests/common.py Outdated Show resolved Hide resolved
api/app/main.py Outdated Show resolved Hide resolved
api/app/health.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Kyubinhan Kyubinhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like PROJECT_NAMESPACE being in the ConfigMap hasn't been resolved but this can be dealt with later. As well as global.config.yml (am I seeing something different? ConfigMap and Secret applied in Openshift still don't match up with our template. I pointed out that bc-fire-weather-base-url, bc-fire-weather-user, bc-fire-weather-filter-id aren't in ConfigMap wps-api-global anymore rather they are in Secret wps-api-global )

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

91.9% 91.9% Coverage
0.0% 0.0% Duplication

@andrea-williams andrea-williams merged commit bc218e3 into main Aug 25, 2020
@andrea-williams andrea-williams deleted the task/patroni_cluster_health/405 branch August 25, 2020 21:53
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
Updated health_check for Patroni cluster health. Outputs 'x out of y pods are healthy'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants