Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hourly actuals bot ("Marvin") #465

Merged
merged 50 commits into from
Sep 2, 2020
Merged

Hourly actuals bot ("Marvin") #465

merged 50 commits into from
Sep 2, 2020

Conversation

Sybrand
Copy link
Contributor

@Sybrand Sybrand commented Aug 31, 2020

  • Added hourly actuals bot (a.k.a. "Marvin")
  • Re-factored Bender to share code base with Marvin.
  • Modified Bender to insert timezone info.
  • Added TZTimeStamp type to enforce presence of timezone info on insertion.
  • Increased CPU limit on api pods from 300m to 500m (hoping to slightly speed up startup).
  • Increased the CPU request (1 to 2) and limit (2 to 4) for the build. (hoping for slightly faster build)
  • Changed env canada to run 13 minutes after the hour (as a courtesy to env. canada, so they don't get flooded on the hour)

@Sybrand Sybrand marked this pull request as ready for review September 1, 2020 21:37
api/Makefile Outdated Show resolved Hide resolved
api/app/db/models.py Outdated Show resolved Hide resolved
api/app/fireweather_bot/common.py Outdated Show resolved Hide resolved
api/app/fireweather_bot/hourly_actuals.py Show resolved Hide resolved
api/pyproject.toml Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

89.2% 89.2% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@Kyubinhan Kyubinhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if you want to spin up other cronjobs in our deployment process here. We do have a ticket for that tho

@Sybrand Sybrand merged commit 8b6dab8 into main Sep 2, 2020
@Sybrand Sybrand deleted the task/bender-hourlies/376 branch September 2, 2020 16:39
vanislekahuna pushed a commit to vanislekahuna/wps that referenced this pull request Sep 19, 2024
- Added hourly actuals bot (a.k.a. "Marvin")
- Re-factored Bender to share code base with Marvin.
- Modified Bender to insert timezone info.
- Added TZTimeStamp type to enforce presence of timezone info on insertion.
- Increased CPU limit on api pods from 300m to 500m (hoping to slightly speed up startup).
- Increased the CPU request (1 to 2) and limit (2 to 4) for the build. (hoping for slightly faster build)
- Changed env canada to run 13 minutes after the hour (as a courtesy to env. canada, so they don't get flooded on the hour)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants