Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svict compatibility #206

Open
arnavaz opened this issue Apr 13, 2020 · 7 comments
Open

svict compatibility #206

arnavaz opened this issue Apr 13, 2020 · 7 comments
Assignees
Labels
awaiting reply waiting for reply from the reporter enhancement good first issue

Comments

@arnavaz
Copy link

arnavaz commented Apr 13, 2020

I am submitting this issue to inquire mavis compatibility with svict SV caller.
https://github.com/vpc-ccg/svict/blob/master/PUBLICATION.md

MAVIS version:

Python version:

OS:

Expected Behaviour

Actual Behaviour

Steps to Reproduce the Behaviour

@creisle creisle self-assigned this May 2, 2020
@creisle
Copy link
Member

creisle commented May 2, 2020

Hi @arnavaz!

Thanks for making this issue. I've taken a quick look at the tool. It looks like they use a non-standard VCF output (custom SVTYPEs ex SVTYPE=INS:R) which means it may require a custom loader. We could also add it as a new type of loader to MAVIS, likely this would be a small adaption to the existing VCF loader

It's also worth pointing out we've only used MAVIS for whole genomes/transcriptomes, use on "targeted sequencing data" may have other issues. For instance one of the metrics we build in the configuration file depends on the reads in the bam files being paired and approximating a normal distribution in their fragment sizes. If you run into any issues when automatically generating your config files its likely related to that. What is the depth of coverage like in these BAMs? are they paired-end reads? what did you use to align then?

I think before we add a loader for this tool type, it would be worth manually converting a couple lines to the standard mavis format and trying to run mavis with that as input along with your BAM files. Pick a couple of SVs you expect to maintain if you can.

Does that sound doable?

@creisle creisle added the awaiting reply waiting for reply from the reporter label May 2, 2020
@arnavaz
Copy link
Author

arnavaz commented May 4, 2020 via email

@arnavaz
Copy link
Author

arnavaz commented May 11, 2020 via email

@creisle
Copy link
Member

creisle commented May 12, 2020

The error is popping up because the argument parser thinks you mean svict as a filepath. The convert command only works with a known input type (see help menu output below)

  --convert <alias> FILEPATH [FILEPATH ...] {manta,delly,transabyss,pindel,chimerascan,mavis,defuse,breakdancer,vcf,breakseq,cnvnator,strelka,starfusion} [stranded]
                        input file conversion for internally supported tools
                        (default: [])

You can input this as type "mavis" instead

mavis config \
--library LIB_test  genome  diseased False  $BAMDIR/test_input.bam \
--convert svict  /mavis_test/test_input.vcf mavis
--assign LIB_test  svict -w $OUTDIR/inut_test/mavis.cfg

I notice from the path however it still has the .vcf extension? the mavis format is tab delimited are you passing a tab delimited file named .vcf or is this a vcf input?

@arnavaz
Copy link
Author

arnavaz commented May 12, 2020 via email

@arnavaz
Copy link
Author

arnavaz commented May 14, 2020 via email

@creisle
Copy link
Member

creisle commented May 15, 2020

@arnavaz awesome! can you put the details for the event you manually converted here? I will use it as a template for writing the parser and adding it as a standard input tool

@creisle creisle added enhancement and removed awaiting reply waiting for reply from the reporter labels May 15, 2020
@creisle creisle added the awaiting reply waiting for reply from the reporter label Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reply waiting for reply from the reporter enhancement good first issue
Projects
None yet
Development

No branches or pull requests

2 participants