Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errors on empty columns #354

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

calchoo
Copy link
Collaborator

@calchoo calchoo commented Jun 26, 2023

Fix summary to bypass some errors when certain columns are empty

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (fb4b645) 86.94% compared to head (d7e7c01) 86.92%.

Additional details and impacted files
@@              Coverage Diff               @@
##           develop_v3     #354      +/-   ##
==============================================
- Coverage       86.94%   86.92%   -0.02%     
==============================================
  Files              57       57              
  Lines            9390     9392       +2     
  Branches         2355     2356       +1     
==============================================
  Hits             8164     8164              
- Misses            751      753       +2     
  Partials          475      475              
Flag Coverage Δ
unittests 86.92% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mavis/summary/main.py 76.22% <0.00%> (-1.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@calchoo calchoo merged commit 6446465 into develop_v3 Aug 16, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants