Support dump and load bytes and add back up limit #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fatanugraha
commented
May 3, 2023
•
fatanugraha
commented
- Added support to back up and restore bytes data.
- Added new flags to stop the backup process after reached certain limit.
asimerel
reviewed
May 8, 2023
dynamodump/dynamodump.py
Outdated
| if isinstance(obj, bytes): | ||
| return base64.b64encode(obj).decode("utf-8") | ||
|
|
||
| return json.JSONEncoder.encoder(self, ob) |
There was a problem hiding this comment.
Suggested change
| return json.JSONEncoder.encoder(self, ob) | |
| return json.JSONEncoder.encoder(self, obj) |
I think there is a typo here.
There was a problem hiding this comment.
Thanks for pointing this out, not sure why this passed my manual testing in the past 🤔
bchew
reviewed
May 9, 2023
dynamodump/dynamodump.py
Outdated
| @@ -1241,6 +1263,9 @@ def main(): | |||
| parser.add_argument( | |||
| "--log", help="Logging level - DEBUG|INFO|WARNING|ERROR|CRITICAL [optional]" | |||
| ) | |||
| parser.add_argument( | |||
| "--limit", help="Limit option for backup, will stop the back up process after number of backed up items exceeded the limit [optional]", type=int | |||
There was a problem hiding this comment.
Could you please replace exceeded with reaches instead
bchew
reviewed
May 9, 2023
There was a problem hiding this comment.
@fatanugraha thanks for the PR! Could you please resolve the linting issue picked up by CI 🙂
|
Kudos, SonarCloud Quality Gate passed!
|
|
Ah apologies, I missed out flake8 lint issues. Pushed the change 🙇 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.