Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exec #56

Closed
marvinwankersteen opened this issue Mar 20, 2017 · 4 comments · Fixed by #151
Closed

Add exec #56

marvinwankersteen opened this issue Mar 20, 2017 · 4 comments · Fixed by #151
Milestone

Comments

@marvinwankersteen
Copy link

Very nice tool!
I have some features that would be nice if you can build that in your tool.

  • Show logs of an container like docker logs -f [--tail=x] <container>
  • Exec like docker exec -ti <container> bash
@bcicen bcicen changed the title Feature request: exec, show logs Add exec, show logs Mar 21, 2017
@wannaknowmo
Copy link

these two features would be awesome.

@kenan-rhoton
Copy link
Contributor

So pretty much both of these features require that we close and reinit the termui properly, however there is currently a bug in termui which makes this simply not work correctly.

I've however submitted a pull request there which fixes the bug. As soon as it's fixed I'll set up a pull request for the Exec feature (I've already got it working except for that issue).

@bcicen, would it be possible to add that fix to your termui fork which we're using until they accept your numfmt change? That would speed up the process

@wannaknowmo
Copy link

@kenan-rhoton thanks for following up

@pete911
Copy link
Contributor

pete911 commented Nov 25, 2017

hi, I have created pull request #105 to view logs

@bcicen bcicen added this to the v0.7 milestone Dec 5, 2017
@bcicen bcicen changed the title Add exec, show logs Add exec Dec 5, 2017
This was referenced Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants