Change error_reporting(0) to ini_set('display_errors', 0); #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,20 +52,23 @@ | |||
| * By default development will show errors but testing and live will hide them. | |||
| */ | |||
|
|
|||
| if (defined('ENVIRONMENT')) | |||
| // By default show all except notifications, deprecated and strict errors | |||
| error_reporting(E_ALL ^ E_NOTICE ^ E_DEPRECATED ^ E_STRICT); | |||
There was a problem hiding this comment.
Locally I want to see every single possible error, warning, notice, etc.
|
@philsturgeon Good call. Although I would like to E_ALL be logged on production too, I guess there is a possibility that, on some setups, it could possibly make php log files too large. What do you think? |
|
Looks good to me. Add a changelog entry and unless Phil and/or Alex disagree I'll merge it. |
|
Seems good. |
|
Might also be a good idea to add this, prior to the |
|
Referencing issue #135. |
narfbg
added a commit
that referenced
this pull request
Jul 10, 2012
Change error_reporting(0) to ini_set('display_errors', 0);
narfbg
added a commit
that referenced
this pull request
Jul 10, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed error reporting regarding issue #1386