Fixed normalization of headers under Apache #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing header normalization routine converts headers provided by Apache (that is, with `-` in the name instead of `_`) to all lowercase, with the exception of the first character. This is different from the expected result, wherein each word of the header is capitalized. For example, `CONTENT-LENGTH` would normalize to `Content-length` instead of the expected `Content-Length`. The reason for this is that the existing code is only converting underscores to spaces, and leaving hyphens untouched. The fix is to replace hyphens with spaces as well before passing the result through `ucwords()`. That fix is included here. Signed-off-by: Daniel Hunsaker <danhunsaker@gmail.com>
narfbg
added a commit
that referenced
this pull request
Dec 31, 2012
Fixed normalization of headers under Apache
chernjie
added a commit
to chernjie/CodeIgniter
that referenced
this pull request
Apr 16, 2013
headers and should be pass through as is. This is a follow up on bcit-ci#2107 (c82b57b) by @danhunsaker;
chernjie
added a commit
to chernjie/CodeIgniter
that referenced
this pull request
Apr 16, 2013
headers and should be pass through as is. This is a follow up on bcit-ci#2107 (c82b57b) by @danhunsaker;
nonchip
pushed a commit
to nonchip/CodeIgniter
that referenced
this pull request
Jun 29, 2013
…lization Fixed normalization of headers under Apache
nonchip
pushed a commit
to nonchip/CodeIgniter
that referenced
this pull request
Jun 29, 2013
headers and should be pass through as is. This is a follow up on bcit-ci#2107 (c82b57b) by @danhunsaker;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing header normalization routine converts headers provided by Apache (that is, with
-in the name instead of_) to all lowercase, with the exception of the first character. This is different from the expected result, wherein each word of the header is capitalized. For example,CONTENT-LENGTHwould normalize toContent-lengthinstead of the expectedContent-Length. The reason for this is that the existing code is only converting underscores to spaces, and leaving hyphens untouched. The fix is to replace hyphens with spaces as well before passing the result throughucwords().That fix is included here.
Signed-off-by: Daniel Hunsaker danhunsaker@gmail.com