-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few examples had http:/example.com instead of http://example.com #398
Conversation
<li><samp>url_title()</samp> will now trim extra dashes from beginning and end.</li> | ||
<li>Fixed a couple of typos in the <a href="helpers/form_helper.html">Form Helper</a> documentation.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we need to add typos to changelog? I know we said "every" change needs it, but... should typos?
haha. I thought it was a bit excessive as well, but I thought I'd be thorough. :) |
Thorough is good... but that is just cocky, haha. I vote 'No' for needing typos in the changelog. I mean, what next... adding changelog items for typos in the changelog? |
Upheld! Can you remove this changelog item? I'm glad for the thought, but typos dont need it. |
@philsturgeon - I was going to merge this but should we wait on this until the new docs are done? |
New docs? You mean the ones using markdown or whatever? |
@kylefarris I think he's referring to converting the docs to sphinx. |
Yup! So, typos for now wont hurt. We are (not that I have done anything yet) in the process of converting the aging HTML documentation into Sphinx, so we can give better styled, searchable and awesome documentation. Any documentation changes since the point of creating this branch COULD be missed, but we can use a little "git-fu" to try and highlight any changes and manually apply them to the new docs if they are still relevant. Either way, for now it doesn't harm anyone to fix typos. Please remove changelog and I'll hit merge. |
The changelog has been removed earlier, Phil. |
So it was! |
A few examples had http:/example.com instead of http://example.com
@nicholasruunu: Yeah, that's what I was thinking about. |
No description provided.