Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few examples had http:/example.com instead of http://example.com #398

Merged
merged 3 commits into from
Sep 7, 2011
Merged

Conversation

genio
Copy link
Contributor

@genio genio commented Sep 6, 2011

No description provided.

<li><samp>url_title()</samp> will now trim extra dashes from beginning and end.</li>
<li>Fixed a couple of typos in the <a href="helpers/form_helper.html">Form Helper</a> documentation.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need to add typos to changelog? I know we said "every" change needs it, but... should typos?

@genio
Copy link
Contributor Author

genio commented Sep 6, 2011

haha. I thought it was a bit excessive as well, but I thought I'd be thorough. :)

@kylefarris
Copy link
Contributor

Thorough is good... but that is just cocky, haha. I vote 'No' for needing typos in the changelog. I mean, what next... adding changelog items for typos in the changelog?

@philsturgeon
Copy link
Contributor

Upheld! Can you remove this changelog item? I'm glad for the thought, but typos dont need it.

@ericlbarnes
Copy link
Contributor

@philsturgeon - I was going to merge this but should we wait on this until the new docs are done?

@kylefarris
Copy link
Contributor

New docs? You mean the ones using markdown or whatever?

@nicholasruunu
Copy link

@kylefarris I think he's referring to converting the docs to sphinx.

@philsturgeon
Copy link
Contributor

Yup! So, typos for now wont hurt. We are (not that I have done anything yet) in the process of converting the aging HTML documentation into Sphinx, so we can give better styled, searchable and awesome documentation.

Any documentation changes since the point of creating this branch COULD be missed, but we can use a little "git-fu" to try and highlight any changes and manually apply them to the new docs if they are still relevant. Either way, for now it doesn't harm anyone to fix typos.

Please remove changelog and I'll hit merge.

@janosrusiczki
Copy link
Contributor

The changelog has been removed earlier, Phil.

@philsturgeon
Copy link
Contributor

So it was!

philsturgeon pushed a commit that referenced this pull request Sep 7, 2011
A few examples had http:/example.com instead of http://example.com
@philsturgeon philsturgeon merged commit ec36dc8 into bcit-ci:develop Sep 7, 2011
@kylefarris
Copy link
Contributor

@nicholasruunu: Yeah, that's what I was thinking about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants