CI_DB_driver->simple_query() doesn't handle the return of CI_DB_driver->initialize() when db_debug options is FALSE #4223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull current develop branch to submit a bug report later
…ze() when db_debug = FALSE #4223
| @@ -774,7 +774,10 @@ public function simple_query($sql) | |||
| { | |||
| if ( ! $this->conn_id) | |||
| { | |||
| $this->initialize(); | |||
| if( !$this->initialize() ) | |||
* fixed PHP code style
| @@ -774,7 +774,10 @@ public function simple_query($sql) | |||
| { | |||
| if ( ! $this->conn_id) | |||
| { | |||
| $this->initialize(); | |||
| if( ! $this->initialize()) | |||
There was a problem hiding this comment.
Still missing a space after the if ...
Also, please leave a comment after you push changes as commits don't issue notifications.
* added missing space character
|
Hi, I added the lost space character again. Hope this does it now ;) regards |
narfbg
added a commit
that referenced
this pull request
Nov 9, 2015
CI_DB_driver->simple_query() to check initialize() return value
narfbg
added a commit
that referenced
this pull request
Nov 9, 2015
CI_DB_driver->simple_query() to check initialize() return value
narfbg
added a commit
that referenced
this pull request
Nov 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview description
Hi @ll,
today I wanted to test my rewritten ci error pages. When I was testing the ENVIROMENT "production", my database configuration will set db_debug to false and I noticed a FATAL error in my php_error.log. :(
I found out that in file system/database/DB_driver.php:777 (the function simple_query() does not respect the return value from $this->initialize(). The $this->initialize() normally never come back on a database connection error because it calls the CI_DB_driver->display_error() method WHEN db_debug option is set to TRUE.
In my production ENV the db_debug is set to FALSE so $this->initialize() returns me an FALSE but simply_query silent discard the return value and call execute(). !!_"*! ;)
regards
j0inty
Steps to reproduce
Use session with qb->pdo->pgsql
config/database.php options
$query_builder = TRUE;
Actual results
CI Error Log Entry:
PHP error_log entry
Expected results
Get only the "Unable to connect ..." message in CI Log and not the "Severity: Error --> Call to a member function ..." from PHP, too.
CI Error Log Entry
The project site is showing up again without to display the db error page as expected. ;)
regards
j0inty