Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Examples: Peak Finding, Impedance #43

Merged
merged 4 commits into from
May 7, 2021
Merged

Conversation

bcliang
Copy link
Owner

@bcliang bcliang commented May 6, 2021

new notebooks added to demo

@bcliang
Copy link
Owner Author

bcliang commented May 6, 2021

This is a bit of a follow-up to #16.

For our lab, we often are monitoring a well-characterized redox reaction at the electrode surface in which case the parser is used simply to extract the current readings at specific voltages. However, there are definitely cases where having peak detection is REALLY important (unknown reactions, drifting electrode potential, etc).

  • Peak detection and area/integration are relatively common use cases in analyzing cyclic voltammetry curves. Should these be methods exposed within the subclass? I think there's a case for that, but I'm not yet convinced "data analysis" should be part of the code base.
  • For the short term, I have written a simple demo python notebook which uses scipy.signal.find_peaks to identify peaks from a CV curve (thanks to code example from @p2jones). Perhaps in a future commit this type of functionality will be rolled in as a class method. Open to ideas/discussion on this topic.
  • The second bit of issue CV add-ons: peak finding, plotting #16 is about visualization of curves. I personally prefer to keep display/plotting of data out of the parser code. Within our lab, some users prefer matplotlib while others opt for more interactive plotting libraries (e.g. plotly)

@p2jones
Copy link
Contributor

p2jones commented May 6, 2021

Glad I could help a little. I agree that including plotting would really bloat the package.

@bcliang bcliang merged commit 400b5e9 into master May 7, 2021
@bcliang bcliang deleted the new-demo-notebooks branch May 7, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants