Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add responsive design to freelancers table #106

Merged
merged 2 commits into from
May 6, 2022

Conversation

cmmata
Copy link
Contributor

@cmmata cmmata commented May 2, 2022

As discussed in #105, the table in freelancers page is not responsive, and it does not work well on mobile devices. This PR breaks the table into a vertical view which renders better in mobiles.

@cmmata
Copy link
Contributor Author

cmmata commented May 2, 2022

The design at the moment looks like this. It's still a WiP, but I wanted to push the current work to start the discussion and see if any of you have proposals in design or anything. The idea was taken from this pen
image

@gonzaloserrano
Copy link
Contributor

Thx, it's a great start!

Some stuff:
CleanShot 2022-05-05 at 14 35 33

Some small improvements:

[1] add some spacing between users.
[2] & [3] remove margin-bottom after lists

With these changes I think we could merge it.

@cmmata
Copy link
Contributor Author

cmmata commented May 6, 2022

Ok @gonzaloserrano, I fixed the [2] and [3] margins. For [1] do you mean to have kind of "separate boxes" between every user? Or simply add more spacing before and after the border? At the moment, I added spacing, here's how it looks like now

image

Copy link
Contributor

@gonzaloserrano gonzaloserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better! I think we can merge it.

@cmmata cmmata marked this pull request as ready for review May 6, 2022 16:09
@cmmata
Copy link
Contributor Author

cmmata commented May 6, 2022

Looks much better! I think we can merge it.

Great! I have removed the draft state. At least this is a first iteration, if you want to remove the table and have only divs with Flexbox it's easy to replicate the mobile view. But I'm not that sure with the desktop view with the column names. We can discuss this in #105 if you want.

@gonzaloserrano gonzaloserrano merged commit c614e8b into bcneng:master May 6, 2022
@gonzaloserrano gonzaloserrano mentioned this pull request May 6, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants