Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/sma 320 issue 164 #170

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Fix/sma 320 issue 164 #170

merged 6 commits into from
Nov 8, 2023

Conversation

livingrockrises
Copy link
Contributor

@livingrockrises livingrockrises commented Nov 6, 2023 •
edited
Loading

Summary

Related Issue: #164

Change Type

  • Bug Fix
  • Refactor
  • New Feature
  • Breaking Change
  • Documentation Update
  • Performance Improvement
  • Other

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Information

Branch Naming

@linear Linear
Copy link

linear bot commented Nov 6, 2023

SMA-320 scw contracts issue # 164

#164

@livingrockrises livingrockrises mentioned this pull request Nov 6, 2023
Closed
filmakarov
filmakarov approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@filmakarov filmakarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@livingrockrises livingrockrises merged commit da1b96e into develop Nov 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmakarov filmakarov filmakarov approved these changes

@Aboudjem Aboudjem Aboudjem approved these changes

@AmanRaj1608 AmanRaj1608 Awaiting requested review from AmanRaj1608

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@livingrockrises @filmakarov @Aboudjem