--all will create duplicate report entries on win32

[j03m]

• Version: 7.0.0
• Platform: win32

This is a bit of a "canned" issue because it assumes that #183 is fixed upstream. But when testing out my fix istanbuljs/test-exclude#44 I noticed there is an additional path casing issue in c8 related to the implementation of --all.

On windows, using local files it is possible for v8 to generate file names like: d:\path\to\my\file.js
note the lower case drive letter.

But later when find --all files the node api post call to resolve will return the same string paths with a upper case drive letter. This is what originally caused #183.

However, once #183 is fixed and test-exclude's shouldInstrument returns true for case mismatches, this additional mismatch in c8's fileIndex Set which we use to track if a file has been seen causes duplicates in the final report:

For example the output might be as follows:

  file1.js     |       0 |        0 |       0 |       0 | 1-36              
  file1.js     |     100 |      100 |     100 |     100 |                   
  file2.js     |       0 |        0 |       0 |       0 | 1-106             
  file2.js     |   90.57 |   

My current thoughts were to replace fileIndex the Set with an overridden Set that would toLowerCase keys when win32 is detected.

[j03m]

That seems to work but I'm having a hard time figuring out how to flex it in a test :/

[bcoe]

@j03m I'd be fine with detecting the environment, and having a test case that only runs in Windows.

[j03m]

@bcoe cool. I'm sort of working on that. Testing it seems to involve changing more code to mock and inject dependencies then I would like. Super messy :/. Trying to figure out a better way.

[j03m]

#192 will fix