Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent changes to v8-to-istanbul cause issues for Node 10 #385

Open
bcoe opened this issue Mar 23, 2022 · 0 comments
Open

Recent changes to v8-to-istanbul cause issues for Node 10 #385

bcoe opened this issue Mar 23, 2022 · 0 comments
Labels

Comments

@bcoe
Copy link
Owner

bcoe commented Mar 23, 2022

Recent changes (istanbuljs/v8-to-istanbul#173) are causing issues for Node 10 tests.

Specifically, it's causing branches to no longer be marked as covered in the following code:

#!/usr/bin/env node
'use strict'

if (true) {
  console.info('hello world')
} else {
  console.info('goodnight moon')
}

I would prefer not to rollback since 173 is a great change to the library, but we should dig into this (as it might be breaking Node 10 users).

CC: @glromeo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant