feat: lookup host ip if none given #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13.
Adds
public-ip@1.2.0as a dependency in order to lookup the public IP of the current host if no IP is given. Cannot usepublic-ipgreater than version 1 if we want to preserve Node 0.10 compatibility.Changes API to make the
iparg optional, allowing just a callback to be given to perform the public IP lookup before determining cloud.Changes CLI to allow no args. This could be considered a breaking change since output and exit code will be different. However, since it's adding functionality rather than taking it away, we can probably just consider this a feature.