-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/Update tests #10
Add/Update tests #10
Conversation
Pull Request Test Coverage Report for Build 1678084013Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
- RFC 1918 - RFC 2544 - RFC 3927 - RFC 6598 - RFC 5737 - RFC 3849 - isValid - isNull - isBroadcast
- RFC 3964 - RFC 6052 - RFC 4380 - RFC 4862 - RFC 4193 - RFC 6145 - RFC 4843 - RFC 7343 - IPv4 - IPv6
- isLocal - isMulticast - isValid - isRoutable - isOnion - getNetwork
ip: minor fix to 16 byte ipv4 writer. pkg: add bufio as a dev dependency for testing. test: add tests for binet.read/binet.write and binet.readBR/binet.writeBW
Also confirmed the test vectors match c-ares, which is awesome (including "no room no room" -- what?!) This LGTM, I'm not sure how else to review without checking all the RFCs, do you have any recommendation on how to understand all this? Update: ran hsd for a while with this branch of binet installed, no issues... is there anything to look for? |
::
).