Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get objects by name #78

Merged
merged 4 commits into from
Apr 4, 2019
Merged

Get objects by name #78

merged 4 commits into from
Apr 4, 2019

Conversation

lacroixthomas
Copy link
Contributor

Add GetObjectByName for map and ObjectGroup

Resolves #49

bcvery1
bcvery1 requested changes Apr 4, 2019
View reviewed changes
Copy link
Owner

@bcvery1 bcvery1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TooHTooH - thanks for the PR, just a few minor changes then I'll merge

objectgroup.go Outdated Show resolved Hide resolved
map.go Outdated Show resolved Hide resolved
map.go Outdated Show resolved Hide resolved
objectgroup.go Outdated Show resolved Hide resolved
map_test.go Show resolved Hide resolved
@bcvery1 bcvery1 merged commit 4c97b92 into bcvery1:master Apr 4, 2019
@bcvery1
Copy link
Owner

bcvery1 commented Apr 4, 2019

Thanks again for your contribution, will merge now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcvery1 bcvery1 bcvery1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lacroixthomas @bcvery1