Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require peer review to merge pulls #18

Closed
thiloshon opened this issue Jan 7, 2018 · 3 comments
Closed

Require peer review to merge pulls #18

thiloshon opened this issue Jan 7, 2018 · 3 comments
Assignees
@vijaybarve @tom-gu
Labels
maintenance question

Comments

@thiloshon
Copy link
Contributor

Shall we make it compulsory for a pull request to be reviewed by at least one other, to be able to merge it with master?

Right now I am able to send a PR and then merge it myself which is not good practice. Review will ensure the PR is in the accepted quality and free from any future conflicts.

https://help.github.com/articles/enabling-required-reviews-for-pull-requests/ this explains how to setup the feature.
@thiloshon thiloshon added this to the V0.1 milestone Jan 7, 2018
@vijaybarve
Copy link
Member

I think this is good practice to let someone else merge pull request after testing it once.

@tom-gu
Copy link
Member

tom-gu commented May 26, 2018

bdtools

@thiloshon
Copy link
Contributor Author

Added compulsory code review and Issues template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vijaybarve vijaybarve

@tom-gu tom-gu

Labels
maintenance question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vijaybarve @tom-gu @thiloshon