Multiple fixes #29
Merged
Multiple fixes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| pip install -r requirements.txt | ||
| "$PYTHON" -mpip install -r requirements.txt |
There was a problem hiding this comment.
After activation, the environment's python and pip will be on the path and should be used; $PYTHON may point outside the virtualenv and is the wrong thing to use here.
There was a problem hiding this comment.
Or you could skip the activation and run $dir/envs/plop-demo/bin/{pip,python} directly.
Fix demo on Python3 including when python=python3. Use venv instead of virtualenv if available. Also create the venv in the demo folder. Fix python -mplop.collector /path/to/script.py; this used to try to save the profile output to profiles/path/to/script.py without creating the intermediate folders (and thus would fail). Now the profile is saved next to the script if given by absolute path.
|
fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix demo on Python3 including when python=python3. Use venv instead of
virtualenv if available.
Also create the venv in the demo folder.
Fix python -mplop.collector /path/to/script.py; this used to try to save
the profile output to profiles/path/to/script.py without creating the
intermediate folders (and thus would fail). Now the profile is saved
next to the script if given by absolute path.