Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time.Ticker gained a Reset function with go1.15 #6

Closed
bdd opened this issue Jun 11, 2020 · 1 comment · Fixed by #7
Closed

time.Ticker gained a Reset function with go1.15 #6

bdd opened this issue Jun 11, 2020 · 1 comment · Fixed by #7

Comments

@bdd
Copy link
Owner

bdd commented Jun 11, 2020

https://tip.golang.org/doc/go1.15#time

Currently we create a new Ticker instance when we get SIGHUP and let the garbage collector do its thing.

runitor/cmd/runitor/main.go

Line 113 in cee6f6e

ticker = time.NewTicker(*every)

This was the function that was missing when first writing this.

Wait for go1.15 to be fully released + 2 weeks.
bdd added a commit that referenced this issue Jun 14, 2020
@bdd
Use new Ticker.Reset(Duration) on SIGALRM
1598845 
Go 1.15 added new `Reset` function to `Ticker`.

Closes #6
@bdd
Copy link
Owner Author

bdd commented Aug 11, 2020

Go 1.15 released today. I'm going to merge this in a week instead of two.

bdd added a commit that referenced this issue Aug 12, 2020
@bdd
Use new Ticker.Reset(Duration) on SIGALRM
7ff414e 
Go 1.15 added new `Reset` function to `Ticker`.

Closes #6
bdd added a commit that referenced this issue Aug 12, 2020
@bdd
Use new Ticker.Reset(Duration) on SIGALRM
8fe8d07 
Go 1.15 added new `Reset` function to `Ticker`.

Closes #6
@bdd bdd mentioned this issue Aug 12, 2020
Merged
@bdd bdd closed this as completed in #7 Aug 16, 2020
bdd added a commit that referenced this issue Aug 16, 2020
@bdd
Use new Ticker.Reset(Duration) on SIGALRM
58f9bef 
Go 1.15 added new `Reset` function to `Ticker`.

Closes #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new Ticker.Reset(Duration) on SIGALRM bdd/runitor
1 participant
@bdd