Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer should be smaller #91

Closed
knightlabs opened this issue Jun 20, 2015 · 5 comments
Closed

Footer should be smaller #91

knightlabs opened this issue Jun 20, 2015 · 5 comments

Comments

@knightlabs
Copy link
Contributor

Having been in the site for a few days, I now think that the footer is just overkill on wasting realestate – either it should be part of the main frame, or it should be significantly smaller – if you lose the MSOL text on the logo, and just have a single row-height MSOL badge icon inline with the text (and even inline the (c) right justified) then you'd have a nice single row footer; but at that point, not sure why you still wouldn't just embed it in the main frame. I'm assuming because the longer pages take forever to get down to the bottom of :)

@threeqube
Copy link

+1. The footer is overwhelming and even more so on mobile.
I'm ok with trying out losing the text in the logo.

@kayaelle
Copy link

Hey there - not sure losing the text will do it since the logo is a little taller. How about removing the logo entirely? Since the footer is anchored (I think we should keep it anchored because we do have a lot of long pages), don't think we need the logo at all.

@knightlabs
Copy link
Contributor Author

I’m good with that too … just commenting :)

-- 
John Knight

bug@knightlabs.com

c +1.202.390.8680

b btl.gs

On Mon, Jun 22, 2015 at 9:11 AM, kayaelle notifications@github.com
wrote:

Hey there - not sure losing the text will do it since the logo is a little taller. How about removing the logo entirely? Since the footer is anchored (I think we should keep it anchored because we do have a lot of long pages), don't think we need the logo at all.

Reply to this email directly or view it on GitHub:
#91 (comment)

@threeqube
Copy link

I think the shorter footer works much better. 👍

screen shot 2015-06-22 at 12 04 06 pm

Will check on prod too once it's pushed there.

@threeqube
Copy link

Pushed to prod. Looks good. 🐨

screen shot 2015-06-24 at 11 52 27 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants