Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #14

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Revert #14

merged 1 commit into from
Aug 21, 2018

Conversation

mkenney
Copy link
Member

@mkenney mkenney commented Aug 21, 2018

Reverts #13

)

// smallFields is a small size data set for benchmarking
var loggerFields = Fields{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loggerFields is unused

@codecov
Copy link

codecov bot commented Aug 21, 2018

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #14   +/-   ##
======================================
  Coverage    61.4%   61.4%           
======================================
  Files          13      13           
  Lines         741     741           
======================================
  Hits          455     455           
  Misses        272     272           
  Partials       14      14
Impacted Files Coverage Δ
log.go 96.77% <ø> (ø) ⬆️
formatter.go 85.04% <100%> (ø) ⬆️
logger.go 45.61% <100%> (ø) ⬆️
entry.go 65.56% <100%> (ø) ⬆️
exported.go 18.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2feac...bac9d31. Read the comment docs.

@mkenney mkenney merged commit 3922eaf into master Aug 21, 2018
@mkenney mkenney deleted the revert-13-std.Logger branch August 21, 2018 18:24
ivucica pushed a commit to ivucica/bdlm-log that referenced this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants