Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of QueryType as parameter #15

Merged
merged 4 commits into from Jul 17, 2022
Merged

Addition of QueryType as parameter #15

merged 4 commits into from Jul 17, 2022

Conversation

niklasenberg
Copy link
Contributor

Added QueryType enum and modified queryBooks() to include queryType parameter + wrote tests

@niklasenberg
QueryType
b4868c0 
Added `QueryType` enum and modified `queryBooks()` to include queryType parameter
@niklasenberg niklasenberg mentioned this pull request May 3, 2022
Closed
@niklasenberg
Copy link
Contributor Author

Resolves #16

@bdlukaa bdlukaa linked an issue May 4, 2022 that may be closed by this pull request
QueryType #16
Closed
@bdlukaa
Copy link
Owner

bdlukaa commented May 4, 2022 •
edited

@niklasenberg the checks are failing

@niklasenberg
Copy link
Contributor Author

@bdlukaa should be alright now, had to rename test-file to make flutter test work

bdlukaa
bdlukaa requested changes Jul 17, 2022
View reviewed changes
test/book_finder_test.dart Show resolved Hide resolved
test/book_finder_test.dart Show resolved Hide resolved
@bdlukaa bdlukaa merged commit 1bad049 into bdlukaa:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdlukaa bdlukaa bdlukaa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QueryType
2 participants
@niklasenberg @bdlukaa