Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the Navigation Pane #31

Merged
merged 37 commits into from
May 17, 2021
Merged

Rework the Navigation Pane #31

merged 37 commits into from
May 17, 2021

Conversation

bdlukaa
Copy link
Owner

@bdlukaa bdlukaa commented May 13, 2021

Reworked the Navigation Pane. Fixes #3

Here is a summary:

  • Removed legacy NavigationPanel and Scaffold
  • Implemented NavigationView and ScaffoldPage.
    • ScaffoldPage is used for layouting, whereas NavigationView is used for navigation
  • Reworked the Navigation Pane Theme. Now acrylicBackgroundColor is used over navigationPanelBackgroundColor, but the background color can be set on NavigationPaneThemeData as well.
  • Implemented open, compact, minimal and top navigation modes.
  • Reworked the example app:
    • Removed the default windows top bar
    • Implemented bitsdojo_window to customize the window app bar

@bdlukaa bdlukaa added the enhancement New feature or request label May 13, 2021
@bdlukaa bdlukaa marked this pull request as draft May 14, 2021 00:45
@bdlukaa bdlukaa self-assigned this May 14, 2021
@bdlukaa bdlukaa marked this pull request as ready for review May 14, 2021 02:04
Copy link
Owner Author

@bdlukaa bdlukaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation updates are needed

CHANGELOG.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@bdlukaa bdlukaa merged commit d855be1 into master May 17, 2021
@bdlukaa bdlukaa deleted the navigation branch May 17, 2021 21:25
WinXaito pushed a commit to WinXaito/fluent_ui that referenced this pull request Nov 28, 2021
dev-hann added a commit to dev-hann/fluent_ui that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Panel rework
1 participant