Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unlatch action #101

Merged
merged 10 commits into from
Mar 18, 2024
Merged

Add unlatch action #101

merged 10 commits into from
Mar 18, 2024

Conversation

m10x
Copy link
Contributor

@m10x m10x commented Mar 16, 2024

added the unlatch action, so door can not only be locked/unlocked but also opened by unlatching the lock.

@m10x m10x mentioned this pull request Mar 16, 2024
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 98.09524% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.83%. Comparing base (2fb5f85) to head (027e7fe).

Files Patch % Lines
yalexs/api.py 83.33% 1 Missing ⚠️
yalexs/api_async.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   95.76%   95.83%   +0.06%     
==========================================
  Files          29       29              
  Lines        3424     3528     +104     
==========================================
+ Hits         3279     3381     +102     
- Misses        145      147       +2     
Flag Coverage Δ
unittests 95.83% <98.09%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m10x
Copy link
Contributor Author

m10x commented Mar 16, 2024

I'll try to add more tests (probably later today)

@m10x
Copy link
Contributor Author

m10x commented Mar 16, 2024

I was confused at firsttest_manual_unlatch_activity_v4, because I misinterpreted Unlatch as Manual Unlatch in my logs. But now the tests should be fine :)

Copy link
Owner

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI is not passing yet

@m10x
Copy link
Contributor Author

m10x commented Mar 16, 2024

CI passed but Codecov is down by 0.03%

@bdraco
Copy link
Owner

bdraco commented Mar 16, 2024

I need to find some time to test this on my production before merging.

Once I do that I'll make a release

Comment on lines +261 to +266
if status in UNLATCHED_STATUS:
return LockStatus.UNLATCHED
if status in UNLOCKED_STATUS:
return LockStatus.UNLOCKED
if status in UNLATCHING_STATUS:
return LockStatus.UNLATCHING
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for HA so I'll need to bump the major version to 3.x

@bdraco bdraco merged commit 26d1305 into bdraco:master Mar 18, 2024
8 checks passed
@bdraco bdraco changed the title added unlatch action Add unlatch action Mar 18, 2024
@bdraco
Copy link
Owner

bdraco commented Mar 18, 2024

published to pypi as 3.0.0

Thanks @m10x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants