-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unlatch action #101
Add unlatch action #101
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 95.76% 95.83% +0.06%
==========================================
Files 29 29
Lines 3424 3528 +104
==========================================
+ Hits 3279 3381 +102
- Misses 145 147 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'll try to add more tests (probably later today) |
I was confused at firsttest_manual_unlatch_activity_v4, because I misinterpreted Unlatch as Manual Unlatch in my logs. But now the tests should be fine :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the CI is not passing yet
CI passed but Codecov is down by 0.03% |
I need to find some time to test this on my production before merging. Once I do that I'll make a release |
if status in UNLATCHED_STATUS: | ||
return LockStatus.UNLATCHED | ||
if status in UNLOCKED_STATUS: | ||
return LockStatus.UNLOCKED | ||
if status in UNLATCHING_STATUS: | ||
return LockStatus.UNLATCHING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change for HA so I'll need to bump the major version to 3.x
published to pypi as 3.0.0 Thanks @m10x |
added the unlatch action, so door can not only be locked/unlocked but also opened by unlatching the lock.