Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for url based BrowserWindowOpener #2

Closed
kumlien opened this issue Dec 7, 2016 · 6 comments
Closed

Support for url based BrowserWindowOpener #2

kumlien opened this issue Dec 7, 2016 · 6 comments

Comments

@kumlien
Copy link

kumlien commented Dec 7, 2016

Hi,
I'm running a project using vaadin-spring-boot-starter. I then run into trouble when trying to use this add-on. Basically the popup window gets the wrong url to the Vaadin bootstrap.js. After some debugging in the SpringVaadinServlet, SpringVaadinServletRequest, BootstrapHandler and searching google + Vaadin forums I found the simplest solution to be to allow this add-on to accept popups based on URL:s in addition to popups based on UI:s. Then I can open a popup using a url pointing to a UI annotated with @springui which makes vaadin-spring-boot happy...
@bdunn44
Copy link
Owner

bdunn44 commented Dec 7, 2016

Not sure I follow the problem or the solution, I've never used Spring. Do you have any code you can share?

If you are recommending an enhancement to the addon pull requests are always welcome.

kumlien added a commit to kumlien/vaadin-oauthpopup that referenced this issue Dec 7, 2016
@kumlien
Proposed solution to bdunn44#2
f5f76a0
kumlien added a commit to kumlien/vaadin-oauthpopup that referenced this issue Dec 7, 2016
@kumlien
bdunn44#2 Removed unused imports
5ca0b3f
@kumlien
Copy link
Author

kumlien commented Dec 7, 2016

Hi,
Not sure I understand 100% either :) But my understanding so far is that when running inside a Spring (Boot) MVC context with Vaadin then everything plays better together if the ui:s are registered as Spring Beans (using the @springui annotation). I'm sure this cat can be skinned in some other way but this approach was the simplest one for me... Thanks for a great add-on btw, saved me quite a few lines of code!

@bdunn44
Copy link
Owner

bdunn44 commented Dec 7, 2016

Thanks for the PR! I'll review, integrate and release

@kumlien
Copy link
Author

kumlien commented Jan 12, 2017

Hi there, any thoughts on this one?
br Svante

bdunn44 pushed a commit that referenced this issue May 25, 2017
@kumlien @bdunn44
Add support for url based popup (#3)
f2a7c56 
* Add support for specifying an URL when creating the OAuthPopupOpener

* Proposed solution to #2

* #2 Removed unused imports
@bdunn44
Copy link
Owner

bdunn44 commented May 25, 2017

Resolved with release 1.0.0!

@bdunn44 bdunn44 closed this as completed May 25, 2017
@kumlien
Copy link
Author

kumlien commented May 26, 2017

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kumlien @bdunn44