Soft-delete deployments #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsun-m
requested review from
luke-lombardi and
nickpetrovic
and removed request for
luke-lombardi
nickpetrovic
reviewed
Jul 2, 2024
pkg/api/v1/deployment.go
Outdated
| @@ -84,6 +86,11 @@ func (g *DeploymentGroup) RetrieveDeployment(ctx echo.Context) error { | |||
|
|
|||
| deploymentId := ctx.Param("deploymentId") | |||
| if deployment, err := g.backendRepo.GetDeploymentByExternalId(ctx.Request().Context(), workspace.Id, deploymentId); err != nil { | |||
| if err == sql.ErrNoRows { | |||
There was a problem hiding this comment.
This doesn't check for bad input (id not being a uuid) and will surface as a 500 when it should probably be a 400.
Check this out.
https://github.com/beam-cloud/beta9/blob/main/pkg/repository/backend_postgres.go#L419-L427
pkg/api/v1/deployment.go
Outdated
| func (g *DeploymentGroup) DeleteDeployment(ctx echo.Context) error { | ||
| cc, ok := ctx.(*auth.HttpAuthContext) | ||
| if !ok { | ||
| return echo.NewHTTPError(http.StatusInternalServerError, "Failed to get auth info") |
There was a problem hiding this comment.
Is this needed? I thought we took care of this here.
pkg/api/v1/deployment.go
Outdated
| // Get deployment | ||
| deploymentWithRelated, err := g.backendRepo.GetDeploymentByExternalId(ctx.Request().Context(), cc.AuthInfo.Workspace.Id, deploymentId) | ||
| if err != nil { | ||
| if err == sql.ErrNoRows { |
There was a problem hiding this comment.
Feels like we're leaking sql into the service. Can we return nil, nil when we don't find a deployment and there isn't an error? See my comment about the bad sql input.
pkg/api/v1/deployment.go
Outdated
| // Delete deployment | ||
| if err := g.backendRepo.DeleteDeployment(ctx.Request().Context(), deploymentWithRelated.Deployment); err != nil { | ||
| return ctx.JSON(http.StatusInternalServerError, map[string]interface{}{ | ||
| "error": "failed to delete deployment", |
There was a problem hiding this comment.
Most of these errors start lower cased, but one doesn't. Can we choose a style and keep it consistent?
nickpetrovic
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.