Fix String.slice deprecation warning in Elixir >= 1.16 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`String.slice(1..-1)` was [hard-deprecated in Elixir 1.16][changelog]. Fix the warning by giving `String.slice(term, 1..-1//1)`. [changelog]: https://github.com/elixir-lang/elixir/releases/tag/v1.16.0
davydog187
approved these changes
Jun 13, 2024
|
I added bump to version 2.1.1 if that suits you. bc1edc0 |
|
There are other pending changes. Please don't include version bumps in PRs, let maintainers handle |
urmastalimaa
force-pushed
the
fix_string_slice_deprecation_warning
branch
from
bc1edc0
to
d4f2c10
Compare
|
Sure thing, removed |
|
@davydog187 Any timeline on a new release? |
|
@halfdan i tried releasing a new version but there's some org secres issues https://github.com/beam-community/avro_ex/actions/runs/10182889703 Working with @doomspork to get this resolved |
|
v2.2.0 has been released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.slice(1..-1)was hard-deprecated in Elixir 1.16. Fix the warning by givingString.slice(term, 1..-1//1).