Extend Stripe.Invoice.t() with from_invoice to allow to track invoice revisions
#770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristantreb
changed the title
Stripe.Invoice.t() with from_invoice to allow tracking invoice revisionsStripe.Invoice.t() with from_invoice to allow to track invoice revisions
snewcomer
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: stripe-elixir does not support the new Stripe API version that allows to edit finalized invoices.
Solution: This PR simply extends
Stripe.Invoice.t()struct with the fieldfrom_invoice. I've tested the code updates end2end.Why is this field useful? It allows to record all changes made on Stripe in 1 webhook event instead of 2 (because you can access the parent invoice id).
Question: I haven't seen tests for the invoice struct's keys. If I missed this, could you wire me to the right file?