Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completed Modules #150

Merged
merged 1 commit into from
May 23, 2024
Merged

Completed Modules #150

merged 1 commit into from
May 23, 2024

Conversation

beanbeanjuice
Copy link
Owner

@beanbeanjuice beanbeanjuice commented May 23, 2024 •
edited

Pull Request

Description

Added toggle-able modules.

Fixes #55

Type of Change

  • Bug Fix (Small Non-Code Breaking Issue)
  • Bug Fix (Critical Code Breaking Issue)
  • Feature (Something New Added to the Code)
  • Improvement (Improving An Existing Section of Code)
  • Documentation Update
  • Security Vulnerability

Changes

  • Internal Code
  • Documentation
  • Other: _____

Test Configuration

  • Hardware:
    • CPU: AMD Ryzen 7 5800x3D
    • GPU: Nvidia RTX 3080
    • RAM: 32 GB DDR4
  • JDK: Java OpenJDK 17

Checklist

  • This pull request has been linked to the appropriate issue on GitHub. (Use the development section on the right.)
  • The code follows the style guidelines.
  • A self-review of the code was performed on GitHub.
  • Appropriate comments and javadocs were added in your code.
  • Appropriate changes have been made to the documentation.
  • Appropriate changes have been made to the README.md file.
  • No warnings are produced when the code is run.
  • Appropriate tests exist for this pull request.
  • New and existing Maven CI tests have passed.
  • The pull request is properly merging into the correct branch.
  • All existing local code has been pushed to the GitHub repository.
  • Changes have been documented in the current draft ProxyChat Releases update.

@beanbeanjuice beanbeanjuice added the feature New feature or request label May 23, 2024
@beanbeanjuice beanbeanjuice self-assigned this May 23, 2024
beanbeanjuice
beanbeanjuice commented May 23, 2024
View reviewed changes
Copy link
Owner Author

@beanbeanjuice beanbeanjuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@beanbeanjuice beanbeanjuice merged commit 3fa1ede into development May 23, 2024
3 checks passed
@beanbeanjuice beanbeanjuice deleted the 55-modules-toggle branch May 23, 2024 05:31
@beanbeanjuice beanbeanjuice linked an issue May 23, 2024 that may be closed by this pull request
[FEATURE]: Make All Modules Toggleable #55
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@beanbeanjuice beanbeanjuice

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Make All Modules Toggleable
1 participant
@beanbeanjuice