Raise for status when Yahoo! returns 403 / use User-Agent header #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes Yahoo! returns 403. This causes a tuple destructuring error later in `parse_response()`, when `.json()` actually does not return anything that can be destructured. The correct defensive behavior is to fail fast and exit here.
Rudd-O
changed the title
|
OK! QA passed. |
|
Please make a stable release with these fixes. Otherwise Beancount users will not be able to use Yahoo! |
|
This is in conflict with current version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Yahoo! returns 403. This causes a tuple destructuring error later in
parse_response(), when.json()actually does not return anything that can be destructured. The correct defensive behavior is to fail fast and exit here.For some symbols, there is no data in the return dictionary. This causes a destructuring
IndexError. We now correctly handle this.Finally, there is a problem when using the default
requestsuser agent (Y! always returns 403 in that case). So we use our own agent to make it work.