Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etl_transform.etl_cities() broken, but only on R CMD check()? #37

Closed
beanumber opened this issue Sep 20, 2017 · 3 comments
Closed

etl_transform.etl_cities() broken, but only on R CMD check()? #37

beanumber opened this issue Sep 20, 2017 · 3 comments

Comments

@beanumber
Copy link
Owner

I'm stumped.

devtools::test()

works just fine. But it fails during

devtools::check()
Status: 1 ERROR
checking tests ... ERROR
  Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  32: readr::parse_number(world_cities$Population..4)
  33: parse_vector(x, col_number(), na = na, locale = locale)
  34: warn_problems(parse_vector_(x, collector, na = na, locale_ = locale))
  35: n_problems(x)
  36: probs(x)
  37: suppressWarnings(x)
  38: withCallingHandlers(expr, warning = function(w) invokeRestart("muffleWarning"))
  39: parse_vector_(x, collector, na = na, locale_ = locale)
  
  testthat results ================================================================
  OK: 29 SKIPPED: 0 FAILED: 1
  1. Error: cities works (@test-etl.R#113) 
  
  Error: testthat unit tests failed
  Execution halted

The offending line of code is

world_cities$city_pop <- readr::parse_number(world_cities$`Population..4`)

I have also tried

world_cities <- mutate_(city_pop = ~readr::parse_number(`Population..4`))

Any ideas?

@beanumber
Copy link
Owner Author

This did not solve the problem (r-lib/testthat#144)

@beanumber
Copy link
Owner Author

It also passes the check on Travis with the release version of R, but fails on win-builder.

@beanumber
Copy link
Owner Author

beanumber added a commit that referenced this issue Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant