-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the dispatch algorithm by avoiding unnecessary ambiguities #151
Conversation
Pull Request Test Coverage Report for Build 9339827200Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from those extra tests, this PR fixes the issues I had with plum and would allow us to stop vendoring it, so I'm supporting it in full.
Moreover, I think this is equivalent to my past PR (albeit much more elegant) so again, I think that's the right approach.
Thanks!
@PhilipVinc Perfect! :) I'll then finalise this PR by adding the missing tests and merge it. |
Co-authored-by: Filippo Vicentini <filippovicentini@gmail.com>
Co-authored-by: Filippo Vicentini <filippovicentini@gmail.com>
@wesselb can I merge? seems all is good |
@PhilipVinc I'm making some final tweaks. If it's ok, I'll merge this in the next ~hour. |
@PhilipVinc Actually, that was faster than expected. I think it looks good. I've added a comment what precisely need to be fixed to fully resolve #117. I think it's feasible to fix, but beyond the scope of this PR. Happy to merge this now? |
happy to! |
Hurray! I'm pretty happy this is finally partially fixed. :) |
@PhilipVinc, I've taken some time to go over #119. I've attempted to implement a very similar approach in a way that makes it very clear where precisely we deviate from the subset relationship and why that is justified.
Would you be able to check if this works for your use case? If it does, I'll add some more extensive tests based on the examples from the other PR.