-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adding a doc with an upgrade guide for users that may be on 1.3 with existing migrations, which this update will replace.
Added short version of the manual upgrade guide, and adjusted the guide to a simpler process. Now instead of having users migrate to `0001`, we have them go to `zero` and then `--fake` migrations back up to latest after upgrades. This is a cleaner process overall and allows for some flexibility in case someone is following the guide at a later date, when/if there are actual changes to concrete models in `mentions` app.
…-q4xr-rc97-m4xx) Upgrading from `celery` 4.x to 5.x has breaking changes! Please read the [celery documentation](https://docs.celeryproject.org/en/stable/history/whatsnew-5.0.html#upgrading-from-celery-4-x) for details on how to migrate.
`psycopg2` is required if your project uses postgres as its database backend, but that is none of `django-wm`'s business.
…to include-migrations
Removed references to URL django-wm.dev as it is no longer used for this project.
Reducing verbosity/improve readability of tests.
Version updated from 1.4 (not used) to 2.0.
…duplicates. Previously returned a list which might include duplicates resulting in duplicate webmention submissions for a single update of the object.
HCard serialization moved from HCard.as_json to utils.serialize_hcard. - Missing HCard is now serialized as null instead of an empty dict.
Created WebmentionTestCase base class to handle common tearDown() logic after tests are run.
- Removed "status" field from JsonResponse - If target is not found, JsonResponse is returned with 404 HTTP status code.
Keep track of attempted submissions vs successful submissions for more useful logging.
…ng mentions. This was always required in the concrete class implementation for proper lookup of incoming mentions but was omitted from the mixin. Any concrete classes that already implement the slug field should be unaffected.
…lass implementations. MentionableMixin.get_absolute_url and MentionableMixin.all_text now raise ImplementationRequired exceptions if they are not overridden. These methods are required for outgoing mentions to work correctly.
…adability. - Removed some confusing 'helper' functions - Replaced weird runtime `constants` values with `testfunc` functions instead. - Clearer testfunc names with docstring descriptions.
…adability. - Removed some confusing 'helper' functions - Replaced weird runtime `constants` values with `testfunc` functions instead. - Clearer testfunc names with docstring descriptions.
- Reduced verbosity of mocking decorations. - Randomised target website URLs at test runtime to ensure correct mocking behaviour.
Moved EndpointDiscoveryTests to separate file. Moved MockResponse to tests.__init__
…int in HTML template <head> element.
…int in HTML template <head> element.
Simplified README.md now consists of an overview of the library with links to docs for installation and upgrades. Added CHANGELOG.md
…project from `project_urls` as PyPi shows this as the source link for the main project. The link is still included in the README.
Replaced minimum >= versions with compatible ~= versions.
Replaced minimum >= versions with compatible ~= versions.
Nosetests is no longer maintained and breaks with Python 3.10, but it's nice to have pretty-printed tests results on older versions. When running on Python 3.10 or later we now default to the default Django test runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important changes
Merges Adding initial migration to mentions app #20 to fix Running makemigrations creates migration files in installed package directory #19 - thanks @GriceTurrble.
Celery version bump to fix Bump celery from 4.2.1 to 5.2.2 in /mentions #18.
Things to be aware of
/get
API response format - see CHANGELOG.md for details.MentionableMixin
now raisesImplementionRequired
exception if either ofget_absolute_url
orall_text
are not overridden - previously failed quietly with a log message.{% webmention_endpoint %}
template tag<head>
to aid endpoint discoverability.Other