Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ES6 unicode code point syntax #2189

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Handle ES6 unicode code point syntax #2189

merged 7 commits into from
Aug 30, 2023

Conversation

roja-a-m
Copy link
Contributor

Description

  • Source branch in your fork has meaningful name (not main)

Fixes Issue: Invalid prettification of object with unicode escape character as object key #2159

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • JavaScript implementation
  • Python implementation (NA if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (NA if
  • README.md documents new feature/option(s)

bitwiseman
bitwiseman approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR!

What you wrote worked within the specific case you were trying to address but didn't cover a number of other places where ES6 code points might appear.

I updated to handle the more general case.

@bitwiseman bitwiseman changed the title Fix - Invalid prettification of object with unicode as key Handle ES6 unicode code point syntax Aug 30, 2023
@bitwiseman bitwiseman merged commit 44b7131 into beautifier:main Aug 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roja-a-m @bitwiseman