Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #339 #354

Closed
wants to merge 2 commits into from
Closed

Fix Issue #339 #354

wants to merge 2 commits into from

Conversation

bthorben
Copy link
Contributor

No description provided.

@bthorben bthorben mentioned this pull request Nov 10, 2013
@bitwiseman
Copy link
Member

Previous pull request conflicts. Please rebase your changes on top of the current master. Perhaps squash the separate commits into one.

@bthorben
Copy link
Contributor Author

I was trying to do that, but found a lot if issues with the single line comment code. The way comments are now handled is a bit of a mess, only the sass/less format supports having a comment in the same line as the property, which is at best inconsistent. It's why the single line comment code looks quite complicated.

I will try to clean that up and merge.

Sent from my mobile

On 12.11.2013, at 01:27, Liam Newman notifications@github.com wrote:

Previous pull request conflicts. Please rebase your changes on top of the current master. Perhaps squash the separate commits into one.


Reply to this email directly or view it on GitHub.

@bitwiseman
Copy link
Member

I'm going to close this for now. Feel free to resubmit when you clean up the merge.

@bitwiseman bitwiseman closed this Feb 24, 2014
@bitwiseman bitwiseman modified the milestone: v1.5.0 Feb 24, 2014
@bitwiseman bitwiseman added this to the v1.5.1 milestone Sep 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants