Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LAST_INSERT_ID() #377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

holtkamp
Copy link
Contributor

No description provided.

@Chris53897
Copy link
Contributor

@holtkamp
I merged this in Dukecity#12
Can you please revert the changes in composer.json for this PR?

@holtkamp
Copy link
Contributor Author

holtkamp commented Jun 16, 2023

@Chris53897 not sure why I applied eb8c54a

I suppose to prevent this failing check: https://github.com/beberlei/DoctrineExtensions/actions/runs/1286680365/jobs/1579854194?pr=377

I am a GIT n00b and worried to mess up the GIT history...

Note that edits are allowed by maintainers, feel free to adapt the PR to your preference!

@Chris53897
Copy link
Contributor

Yor are correct, at that time the change was neccessary.
These changes should be seperated. The change is already in the master Branch https://github.com/beberlei/DoctrineExtensions/blob/master/composer.json#L16
I am not a maintainer. I just want to help to get this merged.

@holtkamp
Copy link
Contributor Author

holtkamp commented Jun 16, 2023

Ok, I followed these steps to remove the last commit which altered composer.json: https://stackoverflow.com/a/51400593, @beberlei could you consider merging this PR now?

@holtkamp
Copy link
Contributor Author

@beberlei, @stevelacey or @stof do you have a moment to have a look at this PR, seems like a small change to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants