-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Sequence method to Feature object #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a method to Feature known as Sequence. This was added anticipating the codon optimization feature in #11, which will require parsing codons from features to build codon tables. Additionally, added manually edited test file t4_intron and fixed one bug in io.go.
This commit adds degenerate bases and makes a public method for ReverseComplement, as the full functionality for reverse complementation was previously split in the getSeq function and reverseComplement, which has been renamed to reverseBase. Degenerate base pairs were added using the table from http://arep.med.harvard.edu/labgc/adnan/projects/Utilities/revcomp.html .
Removed most single or double letter variable names and replaced with more human reable names.
@Koeng101 please review then I'll review again and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a minimally viable way to get the sequence of features. This can be used to fill codon tables for optimization, or to just get the DNA sequence of features.
Testing is currently blocked with bug #24 .
Definitely needs some improvement, but as-is it works for the following from this page (basically, all the Location types that are relevant for CDSs): http://www.insdc.org/files/feature_table.html#3.4.3
Usage: