fixed bug that produced wrong overhang in linear, non-directional, single cut reactions. #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngle cut reactions.
TimothyStiles
commented
Dec 1, 2023
|
|
||
| var overhangSequence string | ||
|
|
||
| if len(forwardOverhangs) > 0 { |
There was a problem hiding this comment.
@Koeng101 should similar logic be implemented elsewhere in this function?
|
@TimothyStiles Why did you nuke the changelog in d0f6ab3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
fixed bug that produced wrong overhangs in linear, non-directional, single cut reactions.
Why are you making these changes?
There was a bug in CutWithEnzyme where in the case of linear, non-directional, single cut reactions, it would assume that the overhangs were produced by a forward facing cut site and return a sequence downstream. In the case of the cut being a reverse cut site it would return the wrong overhangs. This was fixed with a simple if-else
Are any changes breaking? (IMPORTANT)
There are no breaking changes.
Pre-merge checklist
All of these must be satisfied before this PR is considered
ready for merging. Mergeable PRs will be prioritized for review.
primers/primers_test.gofor what this might look like.CHANGELOG.mdin the[Unreleased]section.